Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

24082 Fix Review and Certify Stepper Validation when Incorporation Fails #757

Merged
merged 2 commits into from
Nov 4, 2024
Merged

24082 Fix Review and Certify Stepper Validation when Incorporation Fails #757

merged 2 commits into from
Nov 4, 2024
+14 −3

Conversation

meawong
Copy link
Collaborator

@meawong meawong commented Nov 4, 2024 •
edited
Loading

Issue #: /bcgov/entity#24082

Description of changes:

  • Add reset for CertifyState validity in case Incorporation Application fails when filed (same logic used in Amalgamation and Continuation In)
  • Update patch version

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

@meawong
Copy link
Collaborator Author

meawong commented Nov 4, 2024

/gcbrun

@bcregistry-sre
Copy link
Collaborator

bcregistry-sre commented Nov 4, 2024 •
edited by meawong
Loading

Temporary Url for review: https://business-create-dev--pr-757-gdv5hvdl.web.app

Steps to test:

  1. Open: https://business-create-dev--pr-757-gdv5hvdl.web.app/incorporation-define-company?id=T7ROC9lPOf&accountid=3627 (opens an incorporation application where the class and series name are the same)
  2. Click to Review and Confirm Step
  3. Select File and Pay
  4. Select Ok on the error dialog
  5. See that the Review and Confirm step is not checked and that the application is prevented from proceeding to payment when you try to File and Pay

@meawong meawong changed the title 24082 fix review and certify stepper validation 24082 Fix review and certify stepper validation when Incorporation Fails Nov 4, 2024
@meawong meawong changed the title 24082 Fix review and certify stepper validation when Incorporation Fails 24082 Fix Review and Certify Stepper Validation when Incorporation Fails Nov 4, 2024
@meawong meawong self-assigned this Nov 4, 2024
severinbeauvais
severinbeauvais approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart find! Looks good.

ArwenQin
ArwenQin approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@ArwenQin ArwenQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@meawong meawong merged commit 873515a into bcgov:main Nov 4, 2024
9 of 10 checks passed
@meawong meawong deleted the 24082-Fix-Review-and-Certify-Stepper-Validation branch November 4, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArwenQin ArwenQin ArwenQin approved these changes

@ketaki-deodhar ketaki-deodhar ketaki-deodhar approved these changes

@severinbeauvais severinbeauvais severinbeauvais approved these changes

Assignees

@meawong meawong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@meawong @bcregistry-sre @severinbeauvais @ketaki-deodhar @ArwenQin